Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

`guardian` cant be changed in TadleFactory

Vulnerability Details 🔍 && Impact 📈

At TadleFatory.sol the address guardian is the one in charge of deploying contracts and/or updating them.
Yet this address is set in the constructor and latter there is no way of changing it.

Should this address be compromised there would be no way for a new legit guardian to at least try gain control of the system.

A new guardian could make relatedContracts mapping point to whatever he wants, and this mapping is in key parts across the system like the CapitalPool or in the onlyRelatedContracts modifier at TokenManager.

See here the variable. At first glance as the contract only has 70 lines you can see there is not way of changing the value. None inherited contracts are related to this value either.


Recommendations 🎯

Create a 2tx process to change the guardian address, or at least add a way to change it.
Something similar to Ownable2Step by OpenZeppeling for example.


Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.