Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

Incorrect NatSpec in withdraw() function.

Summary

The natspec description of the withdraw function says that tokenAddress is nativeToken, the _transfer function should send the tokens from capitalPool to the msgsender, but it is actually sent from capitalPool to the tokenManager address itself.
It is only transferred from capitalPool to the sender if tokenAddress is an ERC20 token that differs from nativeToken.

Vulnerability Details

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/TokenManager.sol#L155-L156

Impact

For anyone reading the protocol code, it may be confused with natspec

Tools Used

Manual Review

Recommendations

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.