Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Anyone can update referral information of another user

cryptomoon

Summary

The updateReferrerInfo function contains several critical vulnerabilities that can lead to incorrect behavior, unauthorized updates, and potential exploitation.

Vulnerability Details

updateReferrerInfofunction allows the update of the refferalInfoof any referrer by any user.

https://github.com/Cyfrin/2024-08-tadle/blob/main/src/core/SystemConfig.sol#L69-L72

ReferralInfo storage referralInfo = referralInfoMap[_referrer];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;

Due to this, any user can update the referrerInfoof other users and set themselves as a referrer. referrerInfois accessed in createTakerfunction where it sends some fees to referrerof the taker.

https://github.com/Cyfrin/2024-08-tadle/blob/main/src/core/PreMarkets.sol#L199-L201

ReferralInfo memory referralInfo = systemConfig.getReferralInfo(
_msgSender()
);

Impact

Any user can update the referrerInfoof other users and set themselves as a referrer. referrerInfois accessed in createTakerfunction where it sends some fees to referrerof the taker.

Tools Used

Manual review

Recommendations

User should only be able to update referralInfofor themselves and not other users. Fixed code in updateReferrerInfofunction.

ReferralInfo storage referralInfo = referralInfoMap[msg.sender];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;
Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.