Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

The Initializer can be front run if the function is not called at the moment of deployment

Summary

The only owner which is the caller and sole initializer of the function must make sure to call the initialiization function right at the point of deployment of the contract , the failure to do so is risky.

Vulnerability Details

https://github.com/tadle-com/market-evm/blob/bbb19276f709841d19f299c18f529d09c151c00a/src/core/TokenManager.sol#L45

Impact

The wrapped native token could be at risk as it could be set by another person other than the owner.

Tools Used

Manual Review

Recommendations

Ensure you use the deployment function and automatically call the initialization function right in your setup so that way you wouldn't forget to initialize.

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

[invalid] finding-Admin-Errors-Malicious

The following issues and its duplicates are invalid as admin errors/input validation/malicious intents are1 generally considered invalid based on [codehawks guidelines](https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity#findings-that-may-be-invalid). If they deploy/set inputs of the contracts appropriately, there will be no issue. Additionally admins are trusted as noted in READ.ME they can break certain assumption of the code based on their actions, and

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.