Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

Upgradeable contracts implement initializers and them disable them on implementation contracts

Summary

Protocol contracts are initializing implementation contracts with an owner instead of rendering them unusable.

Vulnerability Details

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/CapitalPool.sol#L17C1-L17C33

Implementation contracts should be unusable but in this case they are all initialized with an owner.

Impact

Implementation contracts are left somewhat usable. Impact is low.

Tools Used

Manual review

Recommendations

Implement an initializer on upgradeable contracts and disable them on implementation contracts.

Updates

Lead Judging Commences

0xnevi Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.