Tadle

Tadle
DeFi
30,000 USDC
View results
Submission Details
Severity: low
Valid

High risk of griefing attack during settlement period in Protected mode

Updates

Lead Judging Commences

0xnevi Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

[invalid] finding-DeliveryPlace-owner-do-not-call-settleAskMaker

Invalid, the makers are incentivized to settle offers to earn maker bonuses when subsequent takers and makers make trade using the original collateral put up for points as well as get back their initial collateral. Additionally, if they do not settle on time, they will lose all their initial collateral, forcing the `owner` to come in and perform the settlement and retrieving that collateral. This is noted as a design decision [here](https://tadle.gitbook.io/tadle/how-tadle-works/features-and-terminologies/settlement-and-collateral-rate) If all else fails, the `owner` can come in to settle as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/DeliveryPlace.sol#L254-L256) and [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/DeliveryPlace.sol#L365-L367) offers to allow closing offers and subsequently allowing refunds. I acknowledge that perhaps a more decentralized

Appeal created

0xbrivan2 Submitter
9 months ago
0xbrivan2 Submitter
9 months ago
0xbrivan2 Submitter
9 months ago
0xnevi Lead Judge
8 months ago
0xnevi Lead Judge 8 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-PreMarkets-last-minute-settle-cascade-collateral-penalize

See details in issue #821 comments

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.