Enabling fixedratio for market place would block all settlements, so all funds will be locked.
Summary
While owner creates market place, he needs to specify if fixedratio is enabled or not in createMarketPlace method. But once it is enabled, all the settlements would be disabled, even those triggered by the owner.
I assume that this flag is for the future, and right now they are creating markets with this set to false. But other then disabling the settlement, this flag has no use so it could be by just set to false before it is implemented.
Because once someone from the protocol team would set it to true by accident, the results would be catastrophic. What is even worst, it would be noticed at the last stage, when all the tokens are already deposited.
Vulnerability Details
Same peace of code is present both in settleAskMaker and settleAskTaker. So all transactions will be reverted.
Impact
All the tokens in the market will be locked.
Tools Used
Manual Review
Recommendations
Set is to false for as long as this is not implemented.
Lead Judging Commences
[invalid] finding-SystemConfig-fixed-ratio
Invalid, design decision, this is decided when market place is created. If a fixed ratio market place is allowed, then admin can simply create a new market place to cater to that in which manual arbitrartion is required instead of allowing settlements by makers, as noted in comments [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/SystemConfig.sol#L88)
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.