Referral logic not properly implemented
Summary
In the SystemConfig's UpdateReferrerInfo(), the referralInfo being updated is the _referrer and not the msg.sender's, leading to unexpected self referrals.
Vulnerability Details
In the above block of code, it is clear that the referralInfo being fetched is not that of the function caller, thus this leads to the _referrer being set as its own referrer every time the function is called, leading to a substancial loss of referral bonuses for users and also completely breaking the referral system of the entire protocol
Tools Used
Manual Review
Recommendations
Change the line where referral info is being fetched to
Lead Judging Commences
finding-SystemConfig-updateReferrerInfo-msgSender
Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.