Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

Settlement should be reversed if sufficient _settledPoints haven't been provided

Summary

Both settleAskMaker and settleAskTaker will make offer settled, even when _settledPoints amount would be to small.

Vulnerability Details

Offer owner might by mistake send only a portion of settlePoints, and that would make offer settled.

Impact

For settled offer he would not be able to provide the remaining points. And he could wrongly assume that he will get some of his collateral, otherwise he would have no reason to send the tokens

Tools Used

Manual Review

Recommendations

Revert transaction

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic

Appeal created

meeve Submitter
about 1 year ago
0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.