Submission Details
Severity: low
InvalidMissing Validation for Offer Type in `listOffer` Function in `PreMarkets` Contract
Updates
Lead Judging Commences
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:
[invalid] finding-PreMarkets-listOffer-validate-offer-Type
Invalid, explicit check not required. listOffer is for subsequent makers that want to sell points again. Based on the original maker creating offer as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L137-L138), if offerType is ASK, the stockType will default to Bid type, so the check [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L330-L332) is sufficient in ensuring only ask offer can be listed
Prize pool breakdown
Total prize
30,000 USDC
nSLOC
1,22924 USDC / LOC
High Medium
25,000 USDC
Low
2,750 USDC
Judges
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.