Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: high
Invalid

[H-2] Platform Fees is only collectd while calling `createTaker` function

Descritption:

The platform fees on Tadle are designed to be collected on every transaction made on the platform, ensuring consistent revenue. However, the current implementation only collects platform fees during the createTaker function call. Other functions likecreateOffer, listOffer, closeOffer, relistOffer, abortBidTaker, abortAskOffer do not collect platform fees. This oversight can result in significant revenue loss for the platform, as users could perform multiple actions without contributing to the platform's revenue.

Tools Used:

Mannually review

Recommendation:

Reevaluate the platform fee collection mechanism and ensure that fees are collected on all relevant function calls that are intended to generate revenue for the platform. This could involve implementing fee triggers within functions ensuring that every transaction or significant action on Tadle contributes to the platform's revenue.

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.