Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

[H-6] Missing Pausing Functionality in many User Facing Functions

Descritption:

The protocol currently lacks a pausing mechanism for several user-facing functions. This functionality is critical for maintaining control over the protocol's operations during a paused state. Without the ability to pause specific functions, critical operations may continue even when the protocol should be halted, leading to potential security vulnerabilities, financial losses, or other unintended consequences. It is crucial to implement a whenNotPaused modifier in all user-facing functions to prevent any operations from occurring during a paused state.

  • Functions that should be paused include:

src
└── core
└── PreMarkets.sol
├── createOffer
├── createTaker
├── listOffer
└── relistOffer

Tools Used:

Mannually review

Recommendation:

Add whenNotPaused modifier to all user-facing functions to prevent any operations when the protocol is paused. This will ensure that no user interactions can occur during a paused state, protecting the protocol from potential vulnerabilities or unintended consequences.

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

[invalid] finding-Rescuable-pause-no-effect

I believe this is informational and non-acceptable severity because: - A single pause on withdraw to be sufficient to pause the markets during times of emergencies, given that is the only function where collateral/point tokens/native ETH can be pulled from market transactions. - Every tadle market place can be switched offline by the admin via [`updateMarketPlaceStatus`](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/SystemConfig.sol#L160-L171) and is checked in market actions via [`checkMarketPlaceStatus`](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/libraries/MarketPlaceLibraries.sol#L54-L67) to be online. This prevents many major market actions including the creation, listing and settlement of offers.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.