SettleAskTaker and SettleAskMaker will revert when marketplaceInfo.tokenAddress = wETH and settlePointTokenAmount > 0
Summary
Due to missing "payable" modifier, user won't be able to deposit Eth to the SettleAskTaker and SettleAskMaker, thereby causing the functions to revert when marketplaceInfo.tokenAddress == wETH and settlePointTokenAmount > 0
Vulnerability Details
In the SettleAskMaker and SettleAskTaker function when settlePointTokenAmount > 0
Users need to deposit settlePointTokenAmount in other to get their pointToken balance
But this process will always revert if marketplaceInfo.tokenAddress == wETH because in order to deposit wETH to the protocol user will have to send eth directly to the protocol, as seen in the tillIn function
This process will always revert resulting in dos of the SettleAskMaker and SettleAskTaker function due to missing payable modifier
Impact
Dos in SettleAskTaker and SettleAskMaker when marketplaceInfo.tokenAddress is wETH and settlePointTokenAmount > 0
Tools Used
Manual review
Recommendations
Add payable modifier to the SettleAskTaker and SettleAskMaker function and also option to send Eth via {value: msg.value} should be added to the point where tillIn function called inside both functions
https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/DeliveryPlace.sol#L377
Lead Judging Commences
finding-TokenManager-tillin-wrapper-inconsistent
Valid medium severity, given it is noted in contest READ.ME that any standard ERC20 tokens should be supported. Although arguably could be low severity, given users can simply unwrap WETH to native ETH and perform the deposits via `tillIn()`, I will leave open for discussions, but taking READ.ME as the source of truth, I believe medium severity is appropriate, given it is explicitly noted that this token should be compatible#9##. The fix would be to utilize a zero address or equivalent to represent native ETH when wrapping to WETH. > Tokens: - ETH - WETH - ERC20 (any token that follows the ERC20 standard)
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.