Calculation of platform fee is not in favor of the protocol.
Summary
PreMarkets.createTake() rounds down calculating the platform fee.
It is not in favor of the protocol.
Vulnerability Details
The relavance code of listOffer() is following.
Impact
Calculation of platform fee is not in favor of the protocol.
Code Snippet
Tools Used
Manual Review
Recommendations
It is recommended to round up.
Lead Judging Commences
finding-PreMarkets-Rounding-Direction
Duplicate of #456, however, for issues noting rounding directions, will be low severity given the impact is not proven sufficiently with a PoC/numerical example and most rounding will not result in significant losses e.g. most examples only proved at most a 1 wei difference when computing `depositAmount/platFormFees` and involves lower amount offers
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.