Tadle
Tadle
DeFi
30,000 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Inadequate Access Control in `updateReferrerInfo()`

tigerfrake

Summary

The updateReferrerInfo() function in the SystemConfig contract lacks proper access control mechanisms. The only restriction is that the _msgSender() must not be the _referrer. This oversight can lead to unauthorized users updating any referrer information.

Vulnerability Details

The function does not restrict who can call it, allowing any user to potentially update the referrer information.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
>> if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
​
​
uint256 referralExtraRate = referralExtraRateMap[_referrer];
uint256 totalRate = baseReferralRate + referralExtraRate;
​
​
if (totalRate > Constants.REFERRAL_RATE_DECIMAL_SCALER) {
revert InvalidTotalRate(totalRate);
}
​
​
if (_referrerRate + _authorityRate != totalRate) {
revert InvalidRate(_referrerRate, _authorityRate, totalRate);
}
​
​
ReferralInfo storage referralInfo = referralInfoMap[_referrer];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;
​
​
//...
}

While the function checks that _msgSender() is not _referrer, it does not ensure that the caller has the appropriate permissions to make such updates.

Impact

Unauthorized updates can compromise the integrity of the referral system

Tools Used

Manual Review

Recommendations

Add the onlyOwner modifier to the updateReferrerInfo() function to restrict access to the contract owner.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
- ) external {
+ ) external onlyOwner {
- if (_msgSender() == _referrer) {
- revert InvalidReferrer(_referrer);
- }
​
​
//...snip...
}
Updates

Lead Judging Commences

0xnevi Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.