Submission Details
Severity: low
ValidHardcoded tradeTax in PreMarktes::createOffer Function
Updates
Lead Judging Commences
Submission Judgement Published
Validated
Assigned finding tags:
finding-PreMarkets-createTaker-offerInfo-tradetax-settledCollateralAmount-not-updated
Borderline low/informational, tradeTax is posted by the original maker when creating an offer within the `makerInfo` mapping as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L112C13-L112C25). and is simply a placeholder for the offerInfo mapping. Given it can impact details of offer regarding the tradeTax, low severity seems appropriate. Similar reasonings apply for settledCollateralAmount.
Prize pool breakdown
Total prize
30,000 USDC
nSLOC
1,22924 USDC / LOC
High Medium
25,000 USDC
Low
2,750 USDC
Judges
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Community Judging
Submissions are being reviewed by the community.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.