Submission Details
Severity:
Gas Costs and Iteration in MysteryBox::claimAllRewards()
Summary
The MysteryBox::claimAllRewards() function iterates over all rewards owned by a user to calculate their value, which can lead to high gas costs and potential failures for users with many rewards.
Vulnerability Details
Affected Code
for (uint256 i = 0; i < rewardsOwned[msg.sender].length; i++) {
totalValue += rewardsOwned[msg.sender][i].value;
}
Impact
A user with a large number of rewards may not be able to claim them all at once due to high gas costs.
Tools Used
Visual Studio Code
Solidity
Foundry
Recommended Mitigation
Allow users to claim rewards in smaller batches or optimize the data structure for more efficient reward value calculations.
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
Gas Limit Exhaustion in `claimAllRewards` Function
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.