Submission Details
Severity:
Potential delete Issue in MysteryBox::transferReward()
Summary
The MysteryBox::transferReward() function uses delete to remove an item from the rewards array, which can leave "holes" in the data structure.
Vulnerability Details
Affected Code
delete rewardsOwned[msg.sender][_index];
Impact
This creates gaps in the rewardsOwned array, leading to potential inefficiencies and unexpected behavior.
Tools Used
Visual Studio Code
Solidity
Foundry
Recommended Mitigation
Use a more efficient method to remove the reward by replacing it with the last item and reducing the array length.
rewardsOwned[msg.sender][_index] = rewardsOwned[msg.sender][rewardsOwned[msg.sender].length - 1];
rewardsOwned[msg.sender].pop();
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.