Submission Details
Severity:
`MysteryBox::claimAllRewards` & `MysteryBox::claimSingleReward` did not follow CEI, may have a reentrancy issue.
Summary
Inside these two function claimAllRewards & claimSingleReward, both do the external call then change the state value.
Vulnerability Details
Impact
It probably will having a reentrancy attack by malicious user.
Tools Used
slither
Recommendations
Following the CEI pattern is better way.
Also could add ReentrancyGuard lib of oppezeppelin.
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`claimAllRewards` reentrancy
`claimSingleReward` reentrancy
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.