Flow

Sablier
FoundryDeFi
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Missing Events for Critical Functions

Description

location : src/SablierFlow.sol

Emitting events in smart contracts is important for transparency and auditability. While the contract emits events for several actions, some critical operations may not have corresponding events, making it difficult to track these actions off-chain.

For example, in the _refund internal function, there's an event emitted:

emit ISablierFlow.RefundFromFlowStream(streamId, sender, amount);

However, there may be other critical functions where events are not emitted, or the events emitted may lack important details.

Impact

Lack of comprehensive event emission can hinder monitoring, debugging, and auditing, making it difficult for users and developers to track contract activity.

Recommendation

  • Ensure All State-Changing Functions Emit Events: Review all functions that modify the contract's state and ensure that they emit appropriate events with sufficient details.

Verify that events include all relevant data needed for off-chain tracking.

Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Too generic
inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.