Flow

Summary

A local variable shadows a state variable and function in the _withdraw function, causing potential code readability and maintainability issues.

Vulnerability Details

Location: src/SablierFlow.sol in the _withdraw function

This local variable shadows:

1. State variable mapping protocolFee in SablierFlowBase

2. Function protocolFee(IERC20) in ISablierFlowBase

Impact

LOW - The shadowing is:

• Limited to internal function scope

• Functionally correct as it reads from the shadowed state mapping

• Only affects code readability and maintenance

Tools Used

slither .

shadowing-local
Impact: Low
Confidence: High

• [ ] ID-23
  SablierFlow._withdraw(uint256,address,uint128).protocolFee shadows:

  • SablierFlowBase.protocolFee (state variable)

  • ISablierFlowBase.protocolFee(IERC20) (function)

src/SablierFlow.sol#L824-L826

manuel code review

Recommendations

Rename the local variable to be more specific:

0r