Submission Details
Severity:
SablierFlowBase::collectProtocolRevenue() and SablierFlowBase::recover() Lack Zero Address Check for to Parameter(Improper Input Validation + Potential Asset Loss)
Description
The functions SablierFlowBase::collectProtocolRevenue() and SablierFlowBase::recover() do not validate the to parameter to ensure it is not the zero address. Allowing transfers to the zero address can inadvertently result in permanent asset loss, as funds sent to the zero address are irretrievable
Impact
Permanent asset loss
Recommended Mitigation
In SablierFlowBase::collectProtocolRevenue(), add the following check:
+ if (to == address(0)) {
+ revert Errors.SablierFlow_WithdrawToZeroAddress(streamId);
+ }
// Check: there is protocol revenue to collect.
if (revenue == 0) {
revert Errors.SablierFlowBase_NoProtocolRevenue(address(token));
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
69929 USDC / LOC
19,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.