Submission Details
Severity:
logic error in covereddeptof
Summary
Vulnerability Details
https://github.com/Cyfrin/2024-10-sablier/blob/main/src/SablierFlow.sol#L468
the covereddeptof(streamid) dot not cover for dept when the balance is equal to the total dept
in this logic below the balance is supposed to be less than or equal to total dept to be able to cover the dept
if (balance < totalDebt) {
return balance;
}
Impact
this logic error could make recipient not to be able to withdraw up to the expected withdrawable amount
Tools Used
manaul review
Recommendations
if (balance <= totalDebt)
{
return balance;
}
Updates
Lead Judging Commences
inallhonesty 8 months ago
Submission Judgement Published Reason: Incorrect statement
Assigned finding tags:
[INVALID]`_coveredDebtOf` discrepancy between condition and comment `balance < totalDebt`
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
69929 USDC / LOC
19,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.