Submission Details
Severity:
Using delegatecall in loop Batch::batch
Summary
Vulnerability Details
When calling delegatecall the same msg.value amount will be accredited multiple times.
There's no explicit handling of msg.value.
Impact
Tools Used
Recommendations
adding a require above of loop
function batch(bytes[] calldata calls) external payable {
uint256 count = calls.length;
+ require(msg.value == 0, "Batch operation requires zero msg.value");
for (uint256 i = 0; i < count; ++i) {
(bool success, bytes memory result) = address(this).delegatecall(calls[i]);
if (!success) {
revert Errors.BatchError(result);
}
}
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
69929 USDC / LOC
19,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.