Flow

Sablier
FoundryDeFi
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Event missing key information

Summary

Since Pause() adjusting the RPS without emmiting AdjustFlowStream, PauseFlowStream should contain the ratePerSecond parameter.

Vulnerability Details

Pause() and Restart() external function calls _adjustRatePerSecond() internal function and doesnt emmit AdjustFlowStream event
and since both this external function doesnt do anything but adjusting the RPS.

https://github.com/Cyfrin/2024-10-sablier/blob/8a2eac7a916080f2022527408b004578b21c51d0/src/SablierFlow.sol#L661C1-L671C6

https://github.com/Cyfrin/2024-10-sablier/blob/8a2eac7a916080f2022527408b004578b21c51d0/src/SablierFlow.sol#L714C1-L725C6

this two events PauseFlowStream and RestartFlowStream should be identical and should both contain the ratePerSecond parameter.

Impact

Event missing key information can be unclear for users.

Tools Used

Manual Review.

Recommendations

Add the missing information.

Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.