Flow
Sablier
FoundryDeFi
20,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

Potential Integer Division Issues

0xserpent

location: /src/SablierFlow.sol

code:

uint256 ratePerSecond = _streams[streamId].ratePerSecond.unwrap();

Impact

  • Description: Division of integers can lead to rounding errors. This is especially problematic in financial applications where precision is crucial.

  • Real-World Consequences: Precision loss can accumulate over multiple transactions, leading to significant discrepancies in balances or expected payouts.

Recommendations

  • Fixed-Point Arithmetic: Use libraries such as ABDK for fixed-point arithmetic to maintain precision.

  • Thorough Testing: Conduct unit tests that focus on edge cases involving division to ensure accuracy.

Updates

Lead Judging Commences

inallhonesty Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
inallhonesty Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.