Flow

Summary

Vulnerability Details

https://github.com/Cyfrin/2024-10-sablier/blob/main/src/abstracts/SablierFlowBase.sol#L262

function setProtocolFee, the only check that is performed is to ensure that the newProtocolFee does not exceed the MAX_FEE. There is no explicit check for a minimum protocol fee

• The function checks if newProtocolFee is greater than MAX_FEE. If it is, the function reverts with an error.

• There is no check for whether newProtocolFee is less than or equal to a minProtocolFee

• Since there is no validation against a minProtocolFee, it is possible for newProtocolFee to be set to a value lower than what might be considered acceptable or sustainable for the protocol

Impact

• If newProtocolFee can be set too low, it might lead to insufficient revenue for the protocol, affecting its operations or sustainability.

Tools Used

manaul

Recommendations

implement a check for newprotocolfee to be greater than minimumfee