Flow
Sablier
FoundryDeFi
20,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

`isStream()` will succeed and return false for non-existent streams

saneryee

Summary

All the public view functions in SablierFlowBase.sol use the notNull modifier to ensure that they revert when called for a non-existent stream.

For example:

function isPaused(uint256 streamId) external view override notNull(streamId) returns (bool result) {
result = _streams[streamId].ratePerSecond.unwrap() == 0;
}

However, the isStream() function is missing this modifier, so will return false instead:

context:SablierFlowBase.sol#L178-L181

/// @inheritdoc ISablierFlowBase
function isStream(uint256 streamId) external view override returns (bool result) {
result = _streams[streamId].isStream;
}

This contradicts the natspec, which says:

context: ISablierFlowBase.sol#L117-L120

/// @notice Retrieves a flag indicating whether the stream exists.
/// @dev Does not revert if `streamId` references a null stream.
/// @param streamId The stream ID for the query.
function isStream(uint256 streamId) external view returns (bool result);

Proof of Concept

function test_isStreamDoesNotRevert() public { assertEq(
flow.isStream(2387333), false);
}

Recommended Mitigation

- function isStream(uint256 streamId) external view override returns (bool result) {
+ function isStream(uint256 streamId) external view override notNull(streamId) returns (bool result) {
result = _streams[streamId].isStream;
}
Updates

Lead Judging Commences

inallhonesty Lead Judge
8 months ago
inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.