SablierFlow.sol
contract allows the sender
to call the createAndDeposit
function to create a new stream and deposit instantly to this stream in one transaction. However, the contract lacks a function that allows the sender
to create and deposit via a broker
.
This creates ambiguity which will lead to users thinking they can not deposit via a broker when they create the stream.
If the sender
and the recipient
have a broker
, sender
is expected to deposit via a broker. This is done to let the fee amount be recieved by an agreed broker
. sender
can call the depositViaBroker
function to achieve this.
Only functions that allow the to create a stream are create
and createAndDeposit
and these functions do not allow the first deposit to be done via a broker
. This incosistency will lead to users thinking they can not deposit via a broker for their first deposit if they intend to create and deposit in the same transaction.
This will lead to the broker
missing out on the fees for the first deposit when sender
intends to create and deposit in the same transaction.
Manual review
Implement a createAndDepositViaBroker
function. An example is shown below.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.