Flow

Summary

The FlowNFTDescriptor contract contains unused parameters in the tokenURI function, potentially reducing clarity and maintainability of the code.

Vulnerability Details

Unused Parameters in tokenURI Function

Impact

The unused parameters, IERC721Metadata sablierFlow and uint256 streamId, do not affect the function output. This can lead to confusion for developers and users, who might assume these parameters impact the resulting URI.

Proof of Concept

In FlowNFTDescriptor.sol, the tokenURI function has parameters defined but not used:

This creates an ambiguous interface, especially if these parameters are intended to customize the tokenURI.

Recommendations

• Integrate sablierFlow and streamId within the tokenURI function logic if they are intended to influence the output.

• If the parameters are placeholders for future development, add clarifying comments, or remove them if unnecessary to avoid confusion.