Flow
Sablier
FoundryDeFi
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of Input Validation in Key Functions

0xserpent

location: /src/abstracts/SablierFlowBase.sol

Description: Certain functions, such as setProtocolFee, do not adequately validate inputs, which could lead to unintended consequences if erroneous values are provided.

  • Code Reference:

protocolFee[token] = newProtocolFee; // No prior check

Impact:

  • Invalid or maliciously crafted inputs could disrupt the normal operation of the contract.

  • Recommendations:

    • Include checks for valid input values, such as ensuring the newProtocolFee is a valid number within acceptable ranges:

require(newProtocolFee >= 0, "Protocol fee cannot be negative");
Updates

Lead Judging Commences

inallhonesty Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.