Flow

Sablier
FoundryDeFi
20,000 USDC
View results
Submission Details
Severity: low
Invalid

NFT Descriptor Management Risks

location: /src/abstracts/SablierFlowBase.sol

Description: Changing the nftDescriptor through the setNFTDescriptor function could lead to inconsistencies in how NFTs are described if the new descriptor is incompatible or malfunctioning.

  • Code Reference:

nftDescriptor = newNFTDescriptor; // No validation or fallback
  • Impact:

    • The new NFT descriptor may not be compatible, leading to incorrect metadata being generated for the NFTs.

  • Recommendations:

    • Validate the newNFTDescriptor to ensure it adheres to the expected interface before updating it. Consider retaining a reference to the previous descriptor for potential rollback.

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.