Flow

Summary

In SablierFlowBase.sol, functions like collectProtocolRevenue and recover handle protocol fee collection without enforcing checks on the accuracy or limits of fees. This could lead to unauthorized revenue manipulation.

Vulnerability Details

The collectProtocolRevenue and recover functions allow the accumulation of fees but lack checks for validating or capping the amounts:

Without additional controls, attackers could potentially manipulate the fee structure and collect excess protocol revenue.

Impact

Uncapped or unchecked fee collection can lead to:

1. Financial inconsistencies in protocol revenue.

2. Potential loss of funds or imbalances in protocol resources.

Tools Used

Manual code review

Recommendations

Add validation checks to ensure fee calculations are accurate and implement caps to prevent excessive revenue accumulation.