Submission Details
Severity:
Missing default protocol fee
Summary
If token is used in a stream and there is no entry for it in mapping(IERC20 token => UD60x18 fee) public override protocolFee; it will return 0.
Vulnerability Details
Impact
Protocol will lose some profits
Tools Used
manual review
Recommendations
Use different structure for protocol fee. For example:
struct ProtocolFee {
bool isSet;
UD60x18 fee;
}
mapping (address token => ProtocolFee fee) protocolFee;
function getFee(address token) internal returns(UD60x18 fee) {
if (protocolFee[token].isSet) {
fee = protocolFee[token].fee;
}else {
// default value
fee = ud(10);
}
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
69929 USDC / LOC
19,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.