Flow
Sablier
FoundryDeFi
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing null stream check for `streamId`

paolinapetkova

Summary

Missing streamId check for null stream in SablierFlowBase::tokenURI().

Vulnerability Details

There is missing null stream check for streamId

Impact

The streamId must not reference a null stream.

Tools Used

Manual review

Recommendations

Add null stream check:

-function tokenURI(uint256 streamId) public view override(IERC721Metadata, ERC721) returns (string memory uri) {
+function tokenURI(uint256 streamId) public view override(IERC721Metadata, ERC721) notNull(streamId) returns (string memory uri) {
// Check: the stream NFT exists.
_requireOwned({ tokenId: streamId });
​
// Generate the URI describing the stream NFT.
uri = nftDescriptor.tokenURI({ sablierFlow: this, streamId: streamId });
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.