Flow

Sablier
FoundryDeFi
20,000 USDC
View results
Submission Details
Severity: medium
Invalid

[M-01] - Unchecked may leads to underflow

Summary

unchecked should only be used when there is a guarantee of no underflows or overflows, or when
they are taken into account. In absence of certainty, it's better to avoid unchecked to favor correctness over gas efficiency and checks should be done before dealing with unchecked updations.

=> https://github.com/Cyfrin/2024-10-sablier/blob/8a2eac7a916080f2022527408b004578b21c51d0/src/abstracts/SablierFlowBase.sol#L220

=> https://github.com/Cyfrin/2024-10-sablier/blob/8a2eac7a916080f2022527408b004578b21c51d0/src/SablierFlow.sol#L698

=> https://github.com/Cyfrin/2024-10-sablier/blob/8a2eac7a916080f2022527408b004578b21c51d0/src/SablierFlow.sol#L839

Impact - medium

Tools Used - manual analysis

Recommendations - use additional checks to ensure that value are updating as intended or do it outside the unchecked block

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.