Starknet Auction

First Flight #26

Starknet Auction

Beginner FriendlyNFT
100 EXP
View results
Submission Details
Severity: high
Valid

[EVMN] Overwritten Bidders' Past Bids

Updates

Lead Judging Commences

bube Lead Judge 3 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Wrong bid amount in `bid` function

In the `bid` function the bid values are stored using `self.bid_values.entry(sender).write(amount)` directly, but this overwrites any previous bids made by the same bidder. Therefore if a participant makes 2 or more bids, the participant can then withdraw only the last value of the last bid. That is incorrect, the protocol should save all bids and a participant should withdraw the value of the all unsuccessful bids.

Support

FAQs

Can’t find an answer? Join our Discord or follow us on Twitter.

Cyfrin
Updraft
CodeHawks
Solodit
Resources