Starknet Auction

First Flight #26
Beginner FriendlyNFT
100 EXP
View results
Submission Details
Severity: high
Valid

[EVMN] Incorrect Asset Transfer Operation

Summary

The incorrect asset transfer operation prevents asset accumulation on the contract, rendering the auction useless.

Vulnerability Details

The code on line 113 uses ERC20.transfer() rather than ERC20.transfer_from(). This means that the asset will not transfer the assets from the bidder to the contract, but rather transfer assets from the contract to itself.

Impact

Potential revert if the contract holds no assets, and no asset accumulation when function bid() is called.

Tools Used

Manual review

Recommendations

Consider replacing transfer() with transfer_from()

Updates

Lead Judging Commences

bube Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Appeal created

bube Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`transfer` instead of `transfer_from`

In the `bid` function is wrongly used `transfer` function instead `transfer_from`.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.