Starknet Auction

First Flight #26
Beginner FriendlyNFT
100 EXP
View results
Submission Details
Severity: high
Valid

[EVMN] Higgest Bidder Can Withdraw Asset

Summary

A highest bidder (the auction winner) can withdraw assets, which means they can get the auctioned item for free.

Vulnerability Details

The function withdraw() will be active once function end() is successfully executed.
However, it does not prevent the auction winner (the highest_bidder) from withdrawing asset. If this occurs, then the highest bidder gets the auctioned item for free. The contract will not be able to return the assets of the losing bidders in full if the auction owner also withdraws.

Impact

The auction winner gets free item.

Tools Used

Manual review.

Recommendations

Consider preventing the auction winner from withdrawing.

Updates

Lead Judging Commences

bube Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

The `highest_bidder` can withdraw the value of all bids

The `withdraw` function allows the participants to receive back the value of all their unsuccessful bids. The problem is that the winner of the auction will receive all bids including the `highest_bid` that should be paid to the NFT owner.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.