Trick or Treat

First Flight #27
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Misleading comment in trickOrTreat function

Summary

In trickOrTreat function there's a comment that says " User needs to call fellForTrick() to finish the transaction". There's no fellForTrick function, instead, it should've said resolveTrick function.

Vulnerability Details

The trickOrTreat function has a comment that misleads users & devs by claiming that in the case of not paying enough ETH in trick case they should finish the transaction by calling the fellForTrick function, that which does not exist.

Impact

Not serious, but can lead to confusion.

Tools Used

Manual review

Recommendations

Change the comment from "// User needs to call fellForTrick() to finish the transaction" to "// User needs to call resolveTrick() to finish the transaction"

Updates

Appeal created

bube Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

[invalid] Wrong comment

This is an informational issue.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.