Wrong event name in mint functions
Summary
Functions that handle minting process trickOrTreat(), mintTreat() emit a misleading Swapped event while no swap occurs. This issue could lead to confusion in 3rd party applications such as frontend of the dApp.
Vulnerability Details
Functions that handle minting process trickOrTreat(), mintTreat() emit a misleading Swapped event while no swap occurs.
emit Swapped(msg.sender, _treatName, tokenId); follows the aforementioned functions, but there's no swapping happening, only minting.
Impact
3rd party applications and users might get confused about what's going on in the protocol.
Tools Used
Manual review.
Recommendations
Change the event name from swapped to minted.
Appeal created
Incorrect Swapped event emission
The protocol emits a Swapped event even when the user has not sent enough ETH to complete the transaction.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.