Submission Details
Severity:
Incorrect initialization of `registry` instance in constructor: `msg.sender` used instead of registry address
Summary
The constructor of GivingThanks accepts address of the registry but uses msg.sender to instantiate it.
Vulnerability Details
The instance of the CharityRegistryshould be initialized with the address of a registry contract. However, it is initialized with msg.sender in the constructor of GivingThanks.
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(msg.sender);
Impact
This way, the registry instance is not created properly.
Tools Used
Manual
Recommendations
Initialize the registrywith the right address.
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
- registry = CharityRegistry(msg.sender);
+ registry = CharityRegistry(_registry);
Updates
Lead Judging Commences
imdheeraj28
about 1 year ago
n0kto about 1 year ago
Submission Judgement Published Assigned finding tags:
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.