Submission Details
Severity:
registry is not set correctly when deploy the contract
Summary
registry is not set correctly when deploy the contract
Vulnerability Details
https://github.com/Cyfrin/2024-11-giving-thanks/blob/main/src/GivingThanks.sol#L16
when init contract, input _registry as the registry. However, it makes msg.sender as the registry instead.
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(msg.sender);
owner = msg.sender;
tokenCounter = 0;
}
Impact
registry is not set correctly when deploy the contract
Tools Used
manualy reviewd
Recommendations
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(_registry);
owner = msg.sender;
tokenCounter = 0;
}
Updates
Lead Judging Commences
n0kto 8 months ago
Submission Judgement Published Assigned finding tags:
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.