DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: low
Invalid

Function `_harvestAndReport` has unused variables `claimable`.

Summary

In all of the three contracts there is a call to the `transmuter` to get the claimable balance of the strategy:

https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyMainnet.sol#L178

https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyArb.sol#L154

https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyOp.sol#L167

This uint256 `claimable` variable that is initialized is never used!

Vulnerability Details

Calling for function and initializing a variable that is never used.

Impact

Unnecessary usage of gas.

Tools Used

Manual review.

Recommendations

Discard that peace of code.

Updates

Appeal created

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.