DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: high
Invalid

Missing Claim Call in _harvestAndReport()

Summary

The _harvestAndReport() function in the StrategyMainnet.sol contract does not include the call to transmuter.claim(claimable, address(this)), which is intended to claim rewards.

Vulnerability Details

Without calling transmuter.claim(), rewards that are due are not harvested, potentially resulting in missed yields. This could negatively affect the strategy's overall performance by not claiming and redeploying rewards.

Impact

This omission prevents the strategy from properly harvesting rewards, impacting the strategy's ability to maximize yield and potentially leading to lower returns.

Tools Used

Manual code review.

Recommendations

Add the transmuter.claim(claimable, address(this)) call within _harvestAndReport() to ensure rewards are properly claimed and redeployed.

Updates

Lead Judging Commences

inallhonesty Lead Judge
8 months ago

Appeal created

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.