DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: high
Invalid

Missing Claim Logic

Summary

In the StrategyArb.sol contract https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyArb.sol#L157

the line for claiming balance from the transmuter is commented out

Impact

If the contract is not claiming the available assets, these resources remain idle in the transmuter and not counted in the total assets. This could leads to inaccurate reporting of _totalAssets and missed opportunities for reinvestment or utilization

Tools Used

Manual review

Recommendations

Uncommented the claim logic or implement a mechanism to claim the assets when necessary.

Updates

Appeal created

inallhonesty Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
inallhonesty Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.