The function includes a note about "possible dormant WETH" and checks the balance of underlying
https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyArb.sol#L168
However, the _swapUnderlyingToAssetslogic is commented out
This results in potentially idle underlying tokens that aren't converted into the desired asset. This could leads to inefficiency if underlying tokens are not usable directly or if they lose value compared to the target asset
Manual Review
Include _swapUnderlyingToAsset logic in this function to ensure all underlying tokens are converted
Clearly document why the swap should happen in a separate function.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.