DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: medium
Valid

Dormant underlying Assets (No Swap Execution)

Summary

The function includes a note about "possible dormant WETH" and checks the balance of underlying
https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyArb.sol#L168
However, the _swapUnderlyingToAssetslogic is commented out

Impact

  • This results in potentially idle underlying tokens that aren't converted into the desired asset. This could leads to inefficiency if underlying tokens are not usable directly or if they lose value compared to the target asset

Tools Used

Manual Review

Recommendations

  • Include _swapUnderlyingToAsset logic in this function to ensure all underlying tokens are converted

  • Clearly document why the swap should happen in a separate function.

Updates

Appeal created

inallhonesty Lead Judge 5 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Incorrect accounting in `_harvestAndReport` claimable should be included

inallhonesty Lead Judge 5 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Incorrect accounting in `_harvestAndReport` claimable should be included

0xhuntoor Auditor
5 months ago
inallhonesty Lead Judge
5 months ago
inallhonesty Lead Judge 5 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Dormant WETH is not properly treated

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.