Submission Details
Severity:
CEI pattern is not followed
Description:
Most of the methods of the contract follow this pattern: (Check, Interaction, Effects)
function _refundERC20(address _to) internal {
// Interaction
i_WETH.safeTransfer(_to, balances[_to][address(i_WETH)]);
i_WBTC.safeTransfer(_to, balances[_to][address(i_WBTC)]);
i_USDC.safeTransfer(_to, balances[_to][address(i_USDC)]);
// Effects
balances[_to][address(i_USDC)] = 0;
balances[_to][address(i_WBTC)] = 0;
balances[_to][address(i_WETH)] = 0;
}
function _refundETH(address payable _to) internal {
// Interaction
uint256 refundValue = etherBalance[_to];
_to.transfer(refundValue);
// Effects
etherBalance[_to] = 0;
}
Recommended Mitigation: Update storage value before interaction.
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.