Submission Details
Severity:
`deadlineSet` allways false. It is not set value when the host sets the deadline.
Description: deadlineSet allways false. It is not set value when the host sets the deadline.
Impact: The fact that the deadlineSet variable is not updated allows the host to change the deadline multiple times. Additionally, the _days parameter is not checked for a value of 0, which could allow the host to set the deadline to the current time, preventing users from being able to refund anymore.
Recommended Mitigation: You can follow these changes:
Check the
_daysvariable is greater than 0.Set
deadlineSettotrueafter change the deadline
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
+ require(_days > 0, "_days is 0");
deadline = block.timestamp + _days * 1 days;
+ deadlineSet = true;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.