Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Missing `zero` address check in `ChristmasDinner:changeHost` function.

Summary:

`ChristmasDinner::changeHost` function does not check weather the address is selected to become host is `zero` address ot not.
```javascript
@> function changeHost(address _newHost) external onlyHost {
if(!participant[_newHost]) {
revert OnlyParticipantsCanBeHost();
}
host = _newHost;
emit NewHost(host);
}
```

Impact:

All funds will stuck in contract.

Recommendations:

The check for zero address have to be added before changing the host.
```diff
function changeHost(address _newHost) external onlyHost {
+ if(_newHost == address(0)) {
+ revert();
+ }
if(!participant[_newHost]) {
revert OnlyParticipantsCanBeHost();
}
host = _newHost;
emit NewHost(host);
}
```
Updates

Lead Judging Commences

0xtimefliez Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.